Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1003 Support Data File visualization #358

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented May 6, 2024

Overview

This PR adds support for Data File statistics. No implementation changes were needed for the visualization, we only need to filter the Data File option from the Submitted Data tab (because it uses the stats API to build the select box).

Change Details (Specifics)

  • Add accessibility coverage for ValidationStatistics
  • Filter "Data File" node from Submitted Data dropdown
    • Added a test case to verify this
  • Add a mock ResponsiveContainer to address missing ResizeObserver implementation in Jest

Related Ticket(s)

CRDCDH-1003

@amattu2 amattu2 added this to the 3.0.0 (PMVP-M1) milestone May 6, 2024
@amattu2 amattu2 changed the title CRDCDH-1003 Filter 'Data File' and add test coverage CRDCDH-1003 Support Data File visualization May 6, 2024
@amattu2 amattu2 closed this May 6, 2024
@amattu2 amattu2 reopened this May 6, 2024
@amattu2 amattu2 marked this pull request as ready for review May 8, 2024 14:19
@amattu2 amattu2 requested a review from Alejandro-Vega May 8, 2024 14:22
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 8a1f019 into 3.0.0 May 8, 2024
5 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1003 branch May 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants