Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1091 Update Metadata Intention labels #356

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented May 2, 2024

Overview

This PR updates the frontend implementation for Metadata Intention labels.

Note

This PR is based off of CRDCDH-922, and that PR should be merged first.

Note

This PR is also related to BE PR CBIIT/crdc-datahub-backend#315

Change Details (Specifics)

  • Update type definition for MetadataIntention
  • Update test cases for new labels
  • Expand Metadata Intention RadioGroup width to accommodate the wider labels

Related Ticket(s)

CRDCDH-1091

@amattu2 amattu2 added 🚧 Do Not Merge This PR is not ready for merging and removed 🚧 Do Not Merge This PR is not ready for merging labels May 2, 2024
@amattu2 amattu2 requested a review from Alejandro-Vega May 3, 2024 14:34
@amattu2 amattu2 added this to the 3.0.0 (PMVP-M1) milestone May 3, 2024
Alejandro-Vega
Alejandro-Vega previously approved these changes May 6, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from CRDCDH-922 to 3.0.0 May 6, 2024 13:49
@Alejandro-Vega Alejandro-Vega dismissed their stale review May 6, 2024 13:49

The base branch was changed.

@Alejandro-Vega Alejandro-Vega merged commit 9672141 into 3.0.0 May 6, 2024
2 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1091 branch May 6, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants