Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1016 Validation Controls memo missing dependency #336

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Apr 8, 2024

Overview

Resolves a MVP-2.1.0 bug where the Data Submission validation controls canValidateMetadata and canValidateFiles is missing the Data Submission status property from the memo hook. This causes the validate button to not become disabled on submit.

Change Details (Specifics)

  • Add Data Submission Status to memoed canValidateXXX variable

Related Ticket(s)

CRDCDH-1016

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone Apr 8, 2024
@amattu2 amattu2 changed the title CRDCDH-1016 Validation Controls canValidateXYZ missing dependency CRDCDH-1016 Validation Controls memo missing dependency Apr 8, 2024
@amattu2 amattu2 requested a review from Alejandro-Vega April 9, 2024 14:58
@amattu2 amattu2 marked this pull request as ready for review April 9, 2024 14:58
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega added the Not Run This PR was not tested locally label Apr 9, 2024
@Alejandro-Vega Alejandro-Vega merged commit ac60ba7 into mvp-2.1.0 Apr 9, 2024
3 checks passed
@Alejandro-Vega Alejandro-Vega deleted the 2.1.0/CRDCDH-1016 branch April 9, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants