Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-974 Auto refresh Validation Results table on validate complete #328

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Apr 2, 2024

Overview

MVP-2.1.0 PR to auto refresh the Validation Results table upon starting or finishing the validation process. Also includes a bug fix for the Validation button itself, where it would never change from "Validating..." if the metadata/file validation status remained the same.

e.g. You validate one time and metadataValidationStatus is Error. You validate again, without uploading anything new, the status quickly becomes Error again and the button never sees any change from Error -> Validating -> Error so it just stays Validating

Change Details (Specifics)

  • Force immediate Data Submission refetch on validate (bug)
  • Refresh QC Results table any time the validation properties update (linked ticket)

Related Ticket(s)

CRDCDH-974

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone Apr 2, 2024
@amattu2 amattu2 changed the title CRDCDH-974 Refresh Validation Results table on submission status change CRDCDH-974 Auto refresh Validation Results table on validate complete Apr 2, 2024
@amattu2 amattu2 marked this pull request as ready for review April 3, 2024 14:50
@amattu2 amattu2 requested a review from Alejandro-Vega April 3, 2024 14:54
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 13a9cfb into mvp-2.1.0 Apr 3, 2024
2 checks passed
@Alejandro-Vega Alejandro-Vega deleted the 2.1.0/CRDCDH-974 branch April 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants