Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-973 Fix Model Navigator <li> must be in a <ul> or <ol> #327

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Apr 1, 2024

Overview

Minor MVP-2 M3 fix for Data Model Navigator. The search result container was overriding the default ul component and using a div instead, making it a invalid DOM structure

Screenshot 2024-04-01 at 12 36 04 PM

Change Details (Specifics)

Related Ticket(s)

CRDCDH-973

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone Apr 1, 2024
@amattu2 amattu2 changed the base branch from main to mvp-2.1.0 April 1, 2024 16:44
@amattu2 amattu2 requested a review from Alejandro-Vega April 1, 2024 16:45
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega added the Not Run This PR was not tested locally label Apr 2, 2024
@Alejandro-Vega Alejandro-Vega merged commit 3e051b0 into mvp-2.1.0 Apr 2, 2024
3 checks passed
@Alejandro-Vega Alejandro-Vega deleted the 2.1.0/CRDCDH-973 branch April 2, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants