Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-861/CRDCDH-865 DMN 508 Audit Issues #303

Merged
merged 2 commits into from
Mar 11, 2024
Merged

CRDCDH-861/CRDCDH-865 DMN 508 Audit Issues #303

merged 2 commits into from
Mar 11, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Mar 11, 2024 •
edited
Loading

Overview

Combined PR to address 508 audit issues identified in CRDCDH-861 (colors) and CRDCDH-865 (interactive controls)

Change Details (Specifics)

  • Upgrade Model Navigator to 1.1.27
  • Update color schemes for
    • Facet Search > Filter By Property > All count values (e.g. "No 221")
    • Facet Search > Search Term > "Clear History" button
    • Facet Search + Graph View > "Clear Search Result" button
    • Graph/Table tabs > Inactive tab button
  • Update improper nesting of interactive controls in Facet Search (Checkbox nested inside a button)

Related Ticket(s)

CRDCDH-861
CRDCDH-865

@amattu2 amattu2 added this to the MVP-2.1.0 (M3) milestone Mar 11, 2024
@amattu2 amattu2 marked this pull request as ready for review March 11, 2024 18:38
@amattu2 amattu2 requested a review from Alejandro-Vega March 11, 2024 18:40
Alejandro-Vega
Alejandro-Vega approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit c80b1b7 into mvp-2.1.0 Mar 11, 2024
1 check passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-861-865 branch March 11, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0 (MVP2-M3)
Development

Successfully merging this pull request may close these issues.
2 participants
@amattu2 @Alejandro-Vega