-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-828 Submission Request Section C Updates #294
Conversation
…ixed type errors caused by this
…n is not selected
@Alejandro-Vega When you get a chance, could you resolve these merge conflicts? |
@amattu2 Merge conflicts have been resolved, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One code issue annotated and a general requirement question added below.
For requirement 4, do we need to update any of the Section C labels or section titles? e.g. should Number of subjects included [...]
become Number of Participants/Subjects [...]
?
Requirements were updated. Moving back to draft. |
…esEnabled property for checkbox
… spacing and text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
Updated the questionnaire, focusing on Section C.
Change Details (Specifics)
Section C:
Cancer Types
dropdownOther cancer types
input and label checkbox to read-only.Cancer Types
input to be optionalOther cancer types
input label. It will enable/disable the input below it. Also, added a property to keep track of this value. It will also clear the input if the checkbox is unselected.Pre-cancer types
from a select dropdown to a 500 chars limit text fieldOther Specie(s) involved
input label. It will enable/disable the input below it. Also, added a property to keep track of this value. It will also clear the input if the checkbox is unselected.Other Specie(s) involved
input field, which has the same logic as the "Other" field described aboveCell lines, model systems
checkboxes andData de-identified
radio buttons from Section BNOTE: There was no mention of "Subject" text to replace with "Participant/Subject" in this section
Section D:
Cell lines, model systems
checkboxes andData de-identified
radio buttons from Section BReview:
Related Ticket(s)
CRDCDH-828