Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-828 Submission Request Section C Updates #294

Merged
merged 25 commits into from
Mar 13, 2024
Merged

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Mar 1, 2024

Overview

Updated the questionnaire, focusing on Section C.

Change Details (Specifics)

Section C:

  • Added "Not Applicable" option to the top of Cancer Types dropdown
  • When "Not Applicable" option is selected, it will unselect other options and only leave the one. If an option is selected after "Not Applicable" is already selected, then it will unselect "Not Applicable". It will also clear and set Other cancer types input and label checkbox to read-only.
  • Updated Cancer Types input to be optional
  • Added checkbox to Other cancer types input label. It will enable/disable the input below it. Also, added a property to keep track of this value. It will also clear the input if the checkbox is unselected.
  • Updated Pre-cancer types from a select dropdown to a 500 chars limit text field
  • Added checkbox to Other Specie(s) involved input label. It will enable/disable the input below it. Also, added a property to keep track of this value. It will also clear the input if the checkbox is unselected.
  • Created Other Specie(s) involved input field, which has the same logic as the "Other" field described above
  • Removed Cell lines, model systems checkboxes and Data de-identified radio buttons from Section B

NOTE: There was no mention of "Subject" text to replace with "Participant/Subject" in this section

Section D:

  • Added Cell lines, model systems checkboxes and Data de-identified radio buttons from Section B

Review:

  • Updated fields to match Section C and Section D changes

Related Ticket(s)

CRDCDH-828

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.1.0 (M3) milestone Mar 1, 2024
@Alejandro-Vega Alejandro-Vega requested a review from amattu2 March 1, 2024 20:54
@amattu2 amattu2 added the 📝 Change Requested This PR has requested changes label Mar 4, 2024
@amattu2
Copy link
Member

amattu2 commented Mar 4, 2024

@Alejandro-Vega When you get a chance, could you resolve these merge conflicts?

@Alejandro-Vega
Copy link
Collaborator Author

@Alejandro-Vega When you get a chance, could you resolve these merge conflicts?

@amattu2 Merge conflicts have been resolved, thanks!

@amattu2 amattu2 removed the 📝 Change Requested This PR has requested changes label Mar 4, 2024
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One code issue annotated and a general requirement question added below.

For requirement 4, do we need to update any of the Section C labels or section titles? e.g. should Number of subjects included [...] become Number of Participants/Subjects [...]?

src/content/questionnaire/sections/C.tsx Outdated Show resolved Hide resolved
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Mar 6, 2024
@Alejandro-Vega
Copy link
Collaborator Author

Requirements were updated. Moving back to draft.

@Alejandro-Vega Alejandro-Vega marked this pull request as draft March 6, 2024 17:33
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review March 11, 2024 20:34
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Mar 11, 2024
@Alejandro-Vega Alejandro-Vega requested a review from amattu2 March 11, 2024 20:34
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amattu2 amattu2 merged commit 71fab18 into mvp-2.1.0 Mar 13, 2024
1 check passed
@amattu2 amattu2 deleted the CRDCDH-828 branch March 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants