Crdcdh 586 #207
Merged
Crdcdh 586 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amattu2
reviewed
Nov 9, 2023
There was a problem hiding this comment.
LGTM. Waiting on @Alejandro-Vega's review then we can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the bug in ticket 586 where the date picker would incorrectly show the error border on the current date.
Change Details (Specifics)
This bug was caused by the date picker returning the incorrect midnight for the day due to daylight savings.
To fix this, I just applied a time zone to the value returned by the date picker, and now it should work.
To test this, I changed the time zone for both node, and the browser following these steps: https://www.browserstack.com/guide/change-time-zone-in-chrome-for-testing.
If you console.log the value in the onChange function prop to to StyledDatePicker, you can see that the value depends on the browser time zone.
This leads me to believe the MUI date picker uses the browser's time zone, so by normalizing the time zone in the code, I believe this issue is fixed.
Related tickets
https://tracker.nci.nih.gov/browse/CRDCDH-586