Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-549 Fixing File Selecting OS Issue #204

Merged
merged 7 commits into from
Nov 8, 2023
Merged

CRDCDH-549 Fixing File Selecting OS Issue #204

merged 7 commits into from
Nov 8, 2023

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Nov 8, 2023 •
edited
Loading

Overview

This PR aims to fix an issue where selecting files are not selecting while on Windows OS.

Change Details (Specifics)

  • Update implementation to use file extension rather than MIME type
  • Fixed issue where if you try to upload the same file it wouldn't always detect it as selected since no "change" occurred with the input

Related Ticket(s)

CRDCDH-549

@Alejandro-Vega Alejandro-Vega added this to the MVP-2.0.0 (M2) milestone Nov 8, 2023
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review November 8, 2023 18:32
@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label Nov 8, 2023
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label Nov 8, 2023
@amattu2 amattu2 merged commit a68db56 into mvp-2 Nov 8, 2023
1 check passed
@amattu2 amattu2 deleted the CRDCDH-549 branch November 8, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

@mtangmt mtangmt Awaiting requested review from mtangmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 (MVP2-M2)
Development

Successfully merging this pull request may close these issues.
2 participants
@Alejandro-Vega @amattu2