Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user admission 거절 시 user state 관리 및 user academic status 로직 수정 #764

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: user admission 거절 시 user state 관리 및 user academic status 로직 수정 #764

merged 3 commits into from
Nov 25, 2024

Conversation

sanggae4133
Copy link
Contributor

🚩 관련사항

관련된 이슈번호 혹은 PR 번호를 기록합니다.

📢 전달사항

  • user admission
    • user admission 거절 시 user state AWAIT로 변경
  • user academic record
    • user academic record create 시 대상 사용자의 변경 타겟 학적 상태가 재학인 경우, 대기 중인 이미 신청한 학적 정보 신청서가 있는지 확인하고, 있다면 닫음 처리
    • semester service 사용, 중복 메서드 제거

📸 스크린샷

📃 진행사항

⚙️ 기타사항

개발기간: 1시간

@sanggae4133 sanggae4133 added bug bug(버그) fix labels Nov 24, 2024
@sanggae4133 sanggae4133 self-assigned this Nov 24, 2024
acidify04
acidify04 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@acidify04 acidify04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

OH-GITAEK
OH-GITAEK approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@OH-GITAEK OH-GITAEK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

zestbear
zestbear approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@zestbear zestbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 .수고많으셨습니다 :)

@sanggae4133 sanggae4133 merged commit f41d06e into dev Nov 25, 2024
1 check passed
@sanggae4133 sanggae4133 deleted the fix/user branch November 25, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OH-GITAEK OH-GITAEK OH-GITAEK approved these changes

@acidify04 acidify04 acidify04 approved these changes

@zestbear zestbear zestbear approved these changes

@win-luck win-luck Awaiting requested review from win-luck

@ja7811 ja7811 Awaiting requested review from ja7811

@pstar987 pstar987 Awaiting requested review from pstar987

@realisshomyang realisshomyang Awaiting requested review from realisshomyang

@givemethatsewon givemethatsewon Awaiting requested review from givemethatsewon

Assignees

@sanggae4133 sanggae4133

Labels
bug bug(버그) fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanggae4133 @zestbear @acidify04 @OH-GITAEK