Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : 전화번호 형식 변경 및 validation 적용 #745

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

OH-GITAEK
Copy link
Contributor

🚩 관련사항

fix : 전화번호 형식 변경 및 validation 적용 #744

📢 전달사항

전화번호가 "01012345678"과 같은 형태로 입력/저장 되고 있던것을 "010-1234-5678"의 형태로 바꾸고 validation적용하였습니다.

📸 스크린샷

올바르지 않은 입력
image

올바른 입력
image

📃 진행사항

  • done1
  • done2 (진행되었어야 하는데 미처 하지 못한 부분 혹은 관련하여 앞으로 진행되어야 하는 부분도 전부 적어서 체크 표시로 관리해주세요.)

⚙️ 기타사항

기타 참고사항을 적어주세요.

개발기간:

@OH-GITAEK OH-GITAEK changed the title Fix/phone number Fix : 전화번호 형식 변경 및 validation 적용 Nov 4, 2024
@OH-GITAEK OH-GITAEK self-assigned this Nov 4, 2024
@OH-GITAEK OH-GITAEK added the fix label Nov 4, 2024
Copy link
Contributor

@acidify04 acidify04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다! 고생하셨습니다

@sanggae4133
Copy link
Contributor

이거 단순히 회원가입 쪽만 전화번호 형식이 있는게 아니라, 학생회비 납부 쪽에도 붙어있어서 전부다 대쉬(-) 들어있는 방식으로 통일 시키거나 그대로 유지하는게 나을 것 같습니다

Copy link
Member

@givemethatsewon givemethatsewon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

Copy link
Contributor

@win-luck win-luck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants