-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): update pydantic requirement from ~=1.0 to ~=2.4 #56
Conversation
Updates the requirements on [pydantic](https://github.com/pydantic/pydantic) to permit the latest version. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v1.0...v2.4.2) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
This is almost certainly broken. Signed-off-by: William Woodruff <[email protected]>
I'll go ahead and fix this up. |
Hmm, weird. It seems that the I've been trying to use @woodruffw do you have a hunch for what this is? And is there a better way to debug proc macros? At the moment, I've been more or less reduced to print debugging. 🥲 |
My best guess is that it's because of a breaking change in pydantic's schema generation: it looks like they're generating
Not a great one, but I generally use a combination of Overall IMO, this is pretty low priority -- we should probably patch this upstream if possible, but Pydantic v1 is still being maintained so there's no urgent need for us to upgrade. So we can hold off on this for a bit and revisit when there's less to do on the PyCA side 🙂 |
A newer version of pydantic exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Updates the requirements on pydantic to permit the latest version.
Release notes
Sourced from pydantic's releases.
Changelog
Sourced from pydantic's changelog.
... (truncated)
Commits
d1634da
Prepare relese 2.4.2 (#7671)0e33bd0
Update Pydantic V1 to 1.10.13 (#7675)154e679
docs: Mixing of V1/V2 models is not supported in generics (#7663)7193693
Added small note to use ValidationInfo over FieldValidationInfo. (#7670)1377c04
Fix xfailed test for generic model signatures (#7658)ea9aa13
Fix models_json_schema for generic models (#7654)97c0199
Fix json schema generation for recursive models (#7653)861cfe3
Revert "Fix typo in docs for new private dunder pydantic method names (#7657)...24e9222
Fix typo in docs for new private dunder pydantic method names (#7657)c04e8e2
Correct allowed formats fordatetime.timedelta
parsing in docs (#7652)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)