Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rfc5280::san::ip-in-dns #369

Merged
merged 3 commits into from
Dec 6, 2024
Merged

add rfc5280::san::ip-in-dns #369

merged 3 commits into from
Dec 6, 2024

Conversation

woodruffw
Copy link
Collaborator

This adds a case where an IP address is encoded as a DNSName, which is invalid.

Signed-off-by: William Woodruff [email protected]

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added the component:tests 🧪 Unit and integration tests label Dec 5, 2024
@woodruffw woodruffw self-assigned this Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

:shipit: No regressions found.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

New testcases

There are new testcases in this change.

gnutls-certtool-3.7.3

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE Chain verification output: Not verified. The certificate is NOT trusted. The name in the certificate does not match the expected.

openssl-3.0.15

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE IP address mismatch

openssl-3.3.2

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE IP address mismatch

openssl-3.2.3

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE IP address mismatch

rustls-webpki

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE subject name validation failed

certvalidator-0.11.1

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE The X.509 certificate provided is not valid for 8.8.8.8. Valid hostnames include: 8.8.8.8

gocryptox509-go1.23.3

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE

openssl-3.4.0

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE IP address mismatch

pyca-cryptography-44.0.0

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE validation failed: leaf certificate has no matching subjectAltName (encountered processing <Certificate(subject=<Name(CN=example.com)>, ...)>)

openssl-3.1.7

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE IP address mismatch

openssl-1.1

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE FAILURE IP address mismatch

rust-webpki

Testcase Expected Result Actual Result Context
rfc5280::san::ip-in-dns FAILURE SKIPPED implementation requires DNS peer names

@woodruffw woodruffw requested a review from alex December 5, 2024 21:13
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw merged commit b9406ff into main Dec 6, 2024
7 checks passed
@woodruffw woodruffw deleted the ww/ip-in-dns-san branch December 6, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant