Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect testcase regressions #201

Merged
merged 41 commits into from
Feb 15, 2024
Merged

Detect testcase regressions #201

merged 41 commits into from
Feb 15, 2024

Conversation

woodruffw
Copy link
Collaborator

@woodruffw woodruffw commented Feb 13, 2024

Adds a workflow for detecting regressions against the latest collected harness results.

Some notes:

  • This also catches things that aren't "true" regressions, e.g. a result going from SKIPPED to a PASS/FAIL state. I could specialize some more to handle these, but I figure there's value in alerting on them as well.
  • The current label change detection is slightly off, since workflows can't trigger other workflows via the default GITHUB_TOKEN. The "correct" way to do this is to use a GitHub App or PAT instead of a workflow's token, but that's a bit overkill.

Closes #197.

Each testsuite is fully independent, no need to leave perf
on the table.

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added component:CI/CD 🤖 CI and CD component:tests 🧪 Unit and integration tests labels Feb 13, 2024
@woodruffw woodruffw self-assigned this Feb 13, 2024
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

No regressions!

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

No regressions 👍

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

No regressions 👍

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

No regressions 👍

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Just to cause a cache miss.

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

:suspect: Regressions found. Review these changes very carefully before continuing!

Sampled regressions: https://github.com/C2SP/x509-limbo/actions/runs/7893899944

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

:suspect: Regressions found. Review these changes very carefully before continuing!

Sampled regressions: https://github.com/C2SP/x509-limbo/actions/runs/7893950308

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

:shipit: No regressions found.

Copy link
Contributor

:shipit: No regressions found.

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

:shipit: No regressions found.

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

:shipit: No regressions found.

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

:shipit: No regressions found.

@woodruffw woodruffw changed the title WIP: detect testcase regressions Detect testcase regressions Feb 13, 2024
For now, since it only half works.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from alex February 14, 2024 21:27
@woodruffw
Copy link
Collaborator Author

I think this is good as an MVP -- I've removed label-checks.yml for now since it's incomplete and needs more thought, and I'll try and do it in a follow-up.

Copy link
Contributor

:shipit: No regressions found.

Signed-off-by: William Woodruff <[email protected]>
Copy link
Contributor

:shipit: No regressions found.

@woodruffw woodruffw mentioned this pull request Feb 14, 2024
2 tasks
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw enabled auto-merge (squash) February 14, 2024 22:25
@woodruffw woodruffw disabled auto-merge February 15, 2024 16:08
@woodruffw woodruffw merged commit 5f2f7b0 into main Feb 15, 2024
7 checks passed
@woodruffw woodruffw deleted the ww/regression-catch branch February 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Protect against test regressions
1 participant