Skip to content

Commit

Permalink
Drop cache-hit check
Browse files Browse the repository at this point in the history
The logic here is faulty: there will be some cache hits for
results that *did* have regressions. So we need to be more
precise here.

Signed-off-by: William Woodruff <[email protected]>
  • Loading branch information
woodruffw committed Feb 13, 2024
1 parent 345db64 commit 75b4026
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ jobs:
id: run-harnesses

- name: run regression checks
# A cache hit means that neither limbo.json nor any of the harnesses
# have changed, so there's no value in checking for regressions.
if: steps.run-harnesses.outputs.cache-hit != 'true'
run: make run ARGS="regression"
env:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
Expand Down

0 comments on commit 75b4026

Please sign in to comment.