[metkit][fdb][eckit] Remove packages and tests

[victoria-cherkas]

eckit

spack_c2sm only adds v1.20.2 which is already in main spack. Additionally there is no branch called '1.20.0' in eckit

• spack_c2sm: https://github.com/C2SM/spack-c2sm/blob/main/repos/c2sm/packages/eckit/package.py
• spack: https://github.com/spack/spack/blob/v0.20.1/var/spack/repos/builtin/packages/eckit/package.py

fdb

spack_c2sm adds branches ("develop","inspect","fastinspect") which are not required anymore. (I added them and I don't know if anyone else uses them but I doubt it. Also better to maintain the main spack fdb package I believe.)

• spack_c2sm: https://github.com/C2SM/spack-c2sm/blob/main/repos/c2sm/packages/fdb/package.py
• spack: https://github.com/spack/spack/blob/v0.20.1/var/spack/repos/builtin/packages/fdb/package.py

metkit

spack_c2sm only adds v1.9.2 which is already in main spack.

• spack_c2sm: https://github.com/C2SM/spack-c2sm/blob/main/repos/c2sm/packages/metkit/package.py

• spack: https://github.com/spack/spack/blob/v0.20.1/var/spack/repos/builtin/packages/metkit/package.py

• check versions in 0.20.1 of spack

[github-actions]

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-26 09:49 UTC

[victoria-cherkas]

@dominichofer Hey Dominic what are your thoughts on removing these all together from spack_c2sm and maintaining instead only in spack/spack ? I'm trying to keep those updated: https://github.com/spack/spack/pulls?q=+is%3Apr+author%3Avictoria-cherkas+

[dominichofer]

I double-checked that the back-port is redundant now 🎉

[victoria-cherkas]

Sorry @dominichofer I just noticed fdb v5.11.17 was not in v0.20.1 of spack, since it just got merged into develop. Shall I add an extension to spack_c2sm ie the below? Before the fdb package in spack_c2sm was just copied rather than an extension anyway.

class Fdb(SpackFdb):
    """FDB (Fields DataBase) is a domain-specific object store developed at
    ECMWF for storing, indexing and retrieving GRIB data."""

    homepage = "https://github.com/ecmwf/fdb"
    url = "https://github.com/ecmwf/fdb/archive/refs/tags/5.7.8.tar.gz"

    version("5.11.17",
            sha256=
            "375c6893c7c60f6fdd666d2abaccb2558667bd450100817c0e1072708ad5591e")

[victoria-cherkas]

Does spack have a regular release schedule do you know?

[dominichofer]

@victoria-cherkas I think this should be sufficient:

class Fdb(SpackFdb):
    """FDB (Fields DataBase) is a domain-specific object store developed at
    ECMWF for storing, indexing and retrieving GRIB data."""

    version("5.11.17", sha256="375c6893c7c60f6fdd666d2abaccb2558667bd450100817c0e1072708ad5591e")

[dominichofer]

Does spack have a regular release schedule do you know?

I don't know.