Simplify icon4py dependencies #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run only selected tests
|
still need to run all the tests, jenkins seems to be down.. |
|
abishekg7
reviewed
Oct 4, 2023
| @@ -181,13 +180,13 @@ def install(self, pkg, spec, prefix): | |||
| elif self.spec.version == ver('=0.0.8'): | |||
| build_dirs = [ | |||
| 'tools', 'model/atmosphere/dycore', | |||
| 'model/atmosphere/diffusion', 'model/driver', 'model/common/' | |||
| 'model/atmosphere/diffusion', 'model/common/' | |||
|
launch jenkins py-icon4py |
|
Could you also open an icon4py PR to undo these changes. Let's remove srun parts and keep the archiveArtifacts in both |
balfrin🟢 unit test
🟢 integration test
🔴 system test
WARNING: Serial tests did not run for system tests |
daint🟢 unit test
🟢 integration test
🔴 system test
WARNING: Serial tests did not run for system tests |
|
I have vacation this week. Will review it on Monday. A brief look at the changeset reveals that you break builds of older version. |
I discussed this also Abishek, in the meantime we have also merged a PR in icon4py which makes a lot of the dependencies optional, with this I can actually run the tests relevant for icon integration by using a Generally, we should have a discussion on versioning and releases. Currently in icon4py so much is going on and changing a lot, that I think it is reasonable to always integrate but we cannot guarantee to never break backward versions. That costs too much time. |
halungge
force-pushed
the
simplify-icon4py-dependencies
branch
from
38bda3b to
fd24c8b
Compare
|
I would actually withdraw all the version of py-icon4py that were running all greenline tests immediately. That is version |
|
@halungge Just let me know once you are ready for a review. |
remove patch file
halungge
force-pushed
the
simplify-icon4py-dependencies
branch
from
ee15320 to
74f9478
Compare
|
launch jenkins py-icon4py |
tsa🟢 unit test
🟢 integration test
|
balfrin🟢 unit test
🟢 integration test
🔴 system test
WARNING: Serial tests did not run for system tests |
daint🟢 unit test
🟢 integration test
🔴 system test
WARNING: Serial tests did not run for system tests |
jonasjucker
reviewed
Oct 11, 2023
jonasjucker
reviewed
Oct 11, 2023
jonasjucker
reviewed
Oct 11, 2023
| when='@0.0.8:', | ||
| type=('build', 'run')) | ||
| depends_on('py-pytest-mpi', when='@0.0.8:', type='build') | ||
| def patch(self): |
There was a problem hiding this comment.
I am not sure if we want to name it patch.
This has a special meaning in spackl, and it will be applied for every install.
I propose to give it a more meaningful name, i.e. like overwrite_pytest_ini or something.
Also you can decorate it with something like
@on_package_attributes(run_tests=True) to be exectuted only in case
--test=root is set.
There was a problem hiding this comment.
yes that is precisely why I use patch. I want it to run before the install
There was a problem hiding this comment.
If it is simply that you can use
@run_before("install") decorator.
Just make sure it is a valid phase for python packages.
There was a problem hiding this comment.
But it's up to your flavour.
jonasjucker
requested changes
Oct 11, 2023
|
launch jenkins py-icon4py icon |
tsa🟢 unit test
|
balfrin🟢 unit test
|
daint🟢 unit test
|
jonasjucker
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes together with icon4py PR C2SM/icon4py#281
In order to simplify the spack build we only take into acccount what is relevant for the blueline (integration with icon-dsl)
--test=rootoption unit