Iter9 #9
Open
Iter9 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edylcrm
reviewed
Nov 13, 2023
| @@ -0,0 +1,51 @@ | |||
| package config | |||
There was a problem hiding this comment.
[BLOCKER] Сделай merge, пожалуйста, первого спринта. Чтобы было понятно какие изменения были
edylcrm
approved these changes
Nov 13, 2023
|
|
||
| func (rh *RedirectHandler) HandleRedirect(storage urlstorage.Storage, log liblog.Logger) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, r *http.Request) { | ||
| if r.Method != http.MethodGet { |
There was a problem hiding this comment.
[LINT] это сам роут проверяет, можно убрать првоерку
| func PanicHandler(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| defer func() { | ||
| if err := recover(); err != nil { |
There was a problem hiding this comment.
[LINT] я бы все таки не отлавливал, верней не маскировал паники, если в приложении случилась паника значит что-то где-то идет не так и нужно чтобы приложение упало и это срочно надо поправить. Если будет паника где-то в оплате, операция списания будет происходить корректно, а операция пополнения будет паников в этом случае лучше чтобы сразу все упало
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iter9 start