Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoBack - if there is a page on the modal stack, pop it without requiring UseModalNavigation #62

Open
wants to merge 5 commits into
base: page-visibility-events
Choose a base branch
from
Open

GoBack - if there is a page on the modal stack, pop it without requiring UseModalNavigation #62

wants to merge 5 commits into from

Conversation

dean-toolhound
Copy link

Also, added TryGetValue to check for existence of parameter and return it's value if it exists.

This is my first PR so not sure if this is the way to do it.

dean-toolhound and others added 5 commits February 6, 2024 13:14
@dean-toolhound
###
d2bd6f3 
- added TryGetValue to NavigationParameters

### Changed
- change GoBack to check if there are pages on modal stack and pop modal page if there is one
@dean-toolhound
INavigation Changes
09e532a
@dean-toolhound
Remove commented out code
e4578af
@dean-toolhound
Clean up
82ca262
@BurkusCat
Merge branch 'page-visibility-events' into main
fd5337d
@BurkusCat
Copy link
Owner

Thanks for the PR, I've added a few small comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dean-toolhound @BurkusCat