-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Uri navigation #23
Merged
Merged
Commits on Oct 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d58180d - Browse repository at this point
Copy the full SHA d58180dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cfe228 - Browse repository at this point
Copy the full SHA 7cfe228View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebda9c9 - Browse repository at this point
Copy the full SHA ebda9c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd35df9 - Browse repository at this point
Copy the full SHA fd35df9View commit details -
Add alternative Navigate implementation
This version looks better since the navigation happens in one go. OnNavigatedTo is only called on the one page you are going to and OnNavigatedFrom only happens on the page you are leaving (rather than every page in between). It probably is possible to make these events happen on the in-between pages if that would be the best behaviour.
Configuration menu - View commit details
-
Copy full SHA for a790a28 - Browse repository at this point
Copy the full SHA a790a28View commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b15c020 - Browse repository at this point
Copy the full SHA b15c020View commit details -
Configuration menu - View commit details
-
Copy full SHA for e89fc48 - Browse repository at this point
Copy the full SHA e89fc48View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae73fac - Browse repository at this point
Copy the full SHA ae73facView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aaa896 - Browse repository at this point
Copy the full SHA 7aaa896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 406a0be - Browse repository at this point
Copy the full SHA 406a0beView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1a791e - Browse repository at this point
Copy the full SHA a1a791eView commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3db0ddb - Browse repository at this point
Copy the full SHA 3db0ddbView commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a090ca7 - Browse repository at this point
Copy the full SHA a090ca7View commit details -
This new design still won't call OnNavigatedFrom/To etc. events for more than two pages. The new method handles absolute and go back a lot cleaner. The end visual result doesn't look as nice though.
Configuration menu - View commit details
-
Copy full SHA for 0ab17bb - Browse repository at this point
Copy the full SHA 0ab17bbView commit details
Commits on Oct 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4d3fc1a - Browse repository at this point
Copy the full SHA 4d3fc1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b74d978 - Browse repository at this point
Copy the full SHA b74d978View commit details -
Configuration menu - View commit details
-
Copy full SHA for a859f38 - Browse repository at this point
Copy the full SHA a859f38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0439ae4 - Browse repository at this point
Copy the full SHA 0439ae4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc82d40 - Browse repository at this point
Copy the full SHA bc82d40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b61d53 - Browse repository at this point
Copy the full SHA 5b61d53View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8fd9f5 - Browse repository at this point
Copy the full SHA c8fd9f5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.