Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds special endings for the crew completing none, or some of the objectives. Syndicate victories are now player-obtainable #698

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Gboster-0
Copy link
Contributor

@Gboster-0 Gboster-0 commented Aug 27, 2024

What this PR does

  • Makes it so world.end() automatically calculates what ending it should have, if not given one

Adds in the following endings:

  • Boring Victory
    Condition: No objectives were failed nor completed. Total nothingness

  • Minor Nanotrasen Victory
    Condition: some of the objectives are completed

Changes the following endings conditions to appear:

  • Nanotrasen Victory
    Condition: All objectives are completed

  • Syndicate Victory
    Condition: if a lot of objectives were failed and not enough completed
    example of when it happens:
    0 completed, 1 failed
    1 completed, 3 failed
    2 completed, 5 failed

Why it should be added to the game

Imo its a bit boring that EVERY victory is a nanotrasen victory without admin intervention.
Thus i think making it so players have an impact on the ending is fun.

@Stalkeros2
Copy link
Collaborator

I would approve this PR, but I am uncertain if something like this'd follow Burger's ideas.

Copy link
Owner

@BurgerLUA BurgerLUA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, I'm just worried there might be a bug somewhere but lets find out.

@Stalkeros2 Stalkeros2 merged commit 9d384dc into BurgerLUA:master Aug 29, 2024
3 checks passed
@Gboster-0 Gboster-0 deleted the round-end branch August 29, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants