Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes it so examining your skills/attributes with more survival levels gives you tips about them #695

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

Gboster-0
Copy link
Contributor

@Gboster-0 Gboster-0 commented Aug 24, 2024

What this PR does

Makes it so skills/attributes by default have very vague descriptions, with your survival expirience increasing the detail in them.
Also adds in a framework for adding tips to skills/attributes, also locked behind survival expirience of course

The survival skill required to unlock the description of a skill/attribute was chosen by taking how early you level it up, and only 2 of the same number exist in the same file.

Currently the tips are:
SKILL_MELEE

  • level 15: "You can perform a strong swing by holding alt and clicking on an enemy.\n
    This deals 2 times the damage but requires a wind-up and consumes some stamina."

SKILL_BLOCK

  • level 7: "When blocking, if an enemy attacks you in 1 second you will parry them, avoiding all damage and possibly stunning the opponent."
  • level 8: "Perfect parrying whilst avoiding all damage, does not grant you blocking expirience."

SKILL_SUMMONING

  • level 30: "Your summoning slots are expanded as you level up summoning, currently you can maintain [math] creatures"

Why it should be added to the game

Currently survival does not do what it states on the tin, and i think it would be neat adding in tips to skills that tell you about obscure things

@BurgerLUA
Copy link
Owner

I'm a little conflicted with making the survival skill give information that's already available. I intended it to be used for stuff like examining the current health value of mobs, and not something that anyone can just look up on the repo. The updated descriptions are nice though.

@Gboster-0
Copy link
Contributor Author

I'm a little conflicted with making the survival skill give information that's already available. I intended it to be used for stuff like examining the current health value of mobs, and not something that anyone can just look up on the repo. The updated descriptions are nice though.

Thats my plan for it for another PR, but imo some of these would be very usefull to have in-game and something that would be annoying to search up, or some more minor tips as most people will never touch the github code.

What i did with blocking and summoning is give the actual end result of calculations of how many minions you have, or how much your blocking is multiplied by via your skills. This is annoying to calculate.

I basically also seperated skill examines into 3 categories that are not really relevant to the PR itself

  • "examines" are just the examinations you used to have, a fairly accurate telling of what the skill does
  • "Tips" are also what they seem, tips about how you can use certain mechanics (like alt+clicking with a melee weapon) to deal a critical strike on an opponent. They are not really explained in-game (you will forget you can crit strike since its ONLY said in the tutorial book)
  • "meta-info" is the most important, and gated behind a very high survival skill, here's where the summoning and defence values are shown to the player

@BurgerLUA BurgerLUA merged commit fe7c6d5 into BurgerLUA:master Nov 27, 2024
3 checks passed
@Gboster-0 Gboster-0 deleted the survival-examines branch December 2, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants