Makes the chat speed up message sending if there are too many messages queued up for a client #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds in a
for()loop in the part of code that sends messages to the chat, that makes the code send 3 messages at once if the queued message list is over 20 objectsWhy it should be added to the game
Currently if you are using a weapon that shoots very rapidly you can end up waiting 20 or more seconds of just standing, waiting to view your XP tab or get any item feedback messages other than combat ones.
This is a bit unintuitive, and can lead players to think that something is lagging while it is not.
Before this PR
2024-08-15.06-38-56.mp4
After this PR
2024-08-16.06-14-13.mp4