Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ad_integration.module #18

Open
wants to merge 2 commits into
base: 8.x-1.x
Choose a base branch
from
Open

Update ad_integration.module #18

wants to merge 2 commits into from

Conversation

zuernBernhard
Copy link

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

dbosen
dbosen reviewed Jun 13, 2017
View reviewed changes
ad_integration.module Outdated
@@ -173,7 +173,7 @@ function _attach_orbyd(array &$page, $advertisingService) {
'advertising_config',
];
$adengine = $advertisingService->getAdEngine();
if ($adengine) {
if (strlen($adengine)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!empty() should cover even more

@zuernBernhard
Copy link
Author

et voila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbosen dbosen dbosen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuernBernhard @dbosen