Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxlength to keywords form fields #16

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

Cyberschorsch
Copy link
Contributor

Keywords in ad-integration can store up to 256 characters. The default maxlength of this field is set to 128 characters. This commit adds a maxlength attribute to the form field.

Make sure these boxes are checked before submitting your pull request - thank you!

  • [x ] All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

Keywords in ad-integration can store up to 256 characters. The default maxlength of this field is set to 128 characters. This commit adds a maxlength attribute to the form field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant