Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fees Calculations #313

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix fees Calculations #313

wants to merge 14 commits into from

Conversation

rcolomina
Copy link
Collaborator

@rcolomina rcolomina commented Apr 9, 2024 •
edited
Loading

  • Fix fees calculations on SOL based escrows
  • Add unit test to make sure fees are well calculated as fee is included within the total amount of the escrow

PENDING

  • Release to devnet and mainnet

@rcolomina rcolomina added the draft draft: in progress do not merge label Apr 9, 2024
@rcolomina rcolomina force-pushed the ruben/fix-on-chain-fees-calculations branch from 02c48fb to e26d6da Compare May 2, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
draft draft: in progress do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rcolomina