Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofi launcher and checks #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jamc-code
Copy link
Contributor

I added checks before querying YouTube to save API calls :)
Also, a rofi launcher for anyone who prefers that over dmenu

@odnar-dev
Copy link

if [[ "${query}" ]]; then
	query="${query// /+}"
else
	echo "No query given. Exiting."; exit 1
fi
if [[ "${video}" ]]; then
	video="https://${video}"
else
	echo "No video selected. Exiting."; exit 1
fi

use instead

[ -z "${query}" ] && echo "No query given. Exiting." && exit 1
query="${query// /+}"
[ -z "${video}" ] && echo "No video selected. Exiting." && exit 1
video="https://${video}"

@jamc-code
Copy link
Contributor Author

ohhhhh, good idea! just updated the PR.

@odnar-dev
Copy link

odnar-dev commented Jun 12, 2021

#9 (comment)
#8 (comment)

look like @Bugswriter has stoped working on this script and started using ytfzf.
i tried ytfzf , but i like myyt more because it's sample and i only need the search function

you can check my fork - pr#11 -- screenshots

  • removed the need for an API KEY
  • added support to rofi
  • now you can select multiple videos and play them with mpv (only on fzf & rofi)
  • merged both scripts into one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants