feat: separate out tests with byte differences in the report #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
force-pushed
the
dlockhart/report-byte-diff
branch
from
d68d774 to
4f7d665
Compare
dbatiste
approved these changes
Aug 12, 2024
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Chrome makes a new release, it can sometimes result in a lot of failed tests due to byte differences. Since these are technically failures (that we're OK with), these get mixed in with potential real failures, which makes reviewing them tedious as you need to scroll through all the failed tests scanning for a legitimate failure.
This change breaks out the "byte diff" failures from the "real" failures in the report, so you can easily filter down to just the real failures and ignore the byte diff ones.