Localize common characters (attempt 2) #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
force-pushed
the
GAUD-7171/localize-common-characters-v2
branch
from
14177cf to
603a8a7
Compare
dlockhart
force-pushed
the
GAUD-7171/localize-common-characters-v2
branch
from
603a8a7 to
2e716c4
Compare
dlockhart
commented
Nov 18, 2024
| @@ -129,12 +158,25 @@ export const getLocalizeClass = (superclass = class {}) => class LocalizeClass e | |||
| const possibleLanguages = this._generatePossibleLanguages(config); | |||
There was a problem hiding this comment.
Change 1: these lines were previously wrapped around an if (config.importFunc) { but components that define their own static resources by manually implementing getLocalizeResources were then not getting their resources filled in.
| } | ||
| return Promise.all(resourcesLoadedPromises); | ||
| } | ||
|
|
||
| static async _getLocalizeResources(langs, { importFunc, osloCollection, useBrowserLangs }) { | ||
|
|
||
| if (importFunc === undefined) return; |
There was a problem hiding this comment.
Change 2: the default implementation of getLocalizeResources just calls this, but importFunc can now be undefined. So we short-circuit and return undefined, but that's going to cause change 3 below...
dbatiste
approved these changes
Nov 18, 2024
bearfriend
approved these changes
Nov 20, 2024
|
🎉 This PR is included in version 3.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to quickly revert the first version of this as it broke a bunch of core unit tests. The reason for that is that the changes caused components wired up to use a
staticcollection of resources (i.e. noimportFunc) to stop working.I'll add comments to call out the changes I made to work around this.