Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switching to use intl v3 #49

Merged
merged 4 commits into from
Jan 6, 2020
Merged

switching to use intl v3 #49

merged 4 commits into from
Jan 6, 2020

Conversation

dlockhart
Copy link
Member

This adopts the breaking changes to our Intl library. Won't be merged until Intl is published at its new location.

dlockhart
dlockhart commented Dec 31, 2019
View reviewed changes
d2l-date-picker-behavior.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@dlockhart
Copy link
Member Author

I just removed the first-day-of-week attribute as well, since it should always come from the descriptor. I'll stop passing it down from datetime-picker in that PR as well.

@dlockhart dlockhart marked this pull request as ready for review January 3, 2020 17:43
@dlockhart dlockhart requested a review from alogan519 as a code owner January 3, 2020 17:43
@dlockhart dlockhart merged commit c6dc64c into master Jan 6, 2020
@dlockhart dlockhart deleted the intl-v3 branch January 6, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanherk svanherk svanherk approved these changes

@dbatiste dbatiste dbatiste approved these changes

@margaree margaree margaree approved these changes

@alogan519 alogan519 Awaiting requested review from alogan519

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlockhart @margaree @dbatiste @svanherk