Don't clear i18n #39
Merged
Don't clear i18n #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
approved these changes
Feb 13, 2019
alogan519
approved these changes
Feb 13, 2019
|
I don't have write access to this repo. Can someone merge this for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell this causes issues in Polymer 2 and 3.
The specific crash I'm seeing occurs here: https://github.com/vaadin/vaadin-date-picker/blob/master/src/vaadin-date-picker-overlay-content.html#L450
If
i18nis cleared, then theformatDatefunction is null and this crashes.I tried at the beginning of this function to manually set
this.localetofrand my date picker opens in French, so I'm assuming that this reassign issue no longer exists.