Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer 3 2018 12 14 155030 #37

Merged
merged 11 commits into from
Dec 31, 2018
Merged

Polymer 3 2018 12 14 155030 #37

merged 11 commits into from
Dec 31, 2018

Conversation

mdulat
Copy link
Contributor

@mdulat mdulat commented Dec 27, 2018

No description provided.

},

attached: function() {
var buttons = document.getElementsByClassName('vaadin-date-picker-overlay paper-button-0');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with shadow DOM? Not sure what the original issue was. Maybe it's no longer needed anyway.

Copy link
Contributor

@mdgbayly mdgbayly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we should add some comments somewhere around the issues trying to use the date picker with slotted content?

@mdulat mdulat merged commit 29c9561 into master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants