Jstefaniuk/hybridize #30
Conversation
jstefaniuk-d2l
commented
May 10, 2018
•
jstefaniuk-d2l
commented
- Make the unit tests work
- Use the new way of styling for the polymer 2 version of the date picker ( see here for docs: https://cdn.vaadin.com/vaadin-date-picker/2.0.2/demo/theming.html )
…'t a property and so is malformed until the point where it gets set in 'ready'
…light can find it
d2l-date-picker-style-modules.html
Outdated
| <link rel="import" href="../polymer/polymer.html"> | ||
| <link rel="import" href="../vaadin-date-picker/vaadin-date-picker-styles.html"> | ||
|
|
||
| <dom-module id="vaadin-overlay-styles" theme-for="vaadin-date-picker-overlay"> |
There was a problem hiding this comment.
The prefix should be d2l-?
…ting the internal value rather than the one passed through formatData), also prefix the style modules with d2l-
… d2l-time-picker rederence
|
🎈 Seems to be working, ready for review |
jstefaniuk-d2l
requested review from
CodeBaboon,
awikkerink,
alogan519,
ChrisKraljevicD2L and
svanherk
bower.json
Outdated
| "d2l-intl": "^0.4.1", | ||
| "iron-a11y-keys": "^1.0.9", | ||
| "app-localize-behavior": "~1.0.2", | ||
| "app-localize-behavior": "PolymerElements/app-localize-behavior#1 - 2", |
There was a problem hiding this comment.
Not needed as part of the hybridization, but I'd recommend getting this switched over to d2l-localize-behavior -- it should let you remove some of your resolution code and will ensure dates are formatted and parsed according to a user's preferences within Brightspace.
bower.json
Outdated
| "d2l-polymer-behaviors": "^1.0.0" | ||
| "d2l-polymer-behaviors": "^1.0.0", | ||
| "vaadin-date-picker": "^2.0.0", | ||
| "webcomponentsjs": "^v1.0.0" |
There was a problem hiding this comment.
I'm surprised you need resolutions behind just webcomponentsjs....
There was a problem hiding this comment.
I think I added that in earlier on, since now it seems like it's no longer used 👍
d2l-date-picker-style-modules.html
Outdated
| } | ||
|
|
||
| [part~="overlay-header"] { | ||
| background-color: var(--d2l-color-celestine); |
There was a problem hiding this comment.
If you're referencing the colors CSS variables, you should import d2l-colors.html explicitly -- just in case it gets removed from another import later.
d2l-date-picker-style-modules.html
Outdated
|
|
||
| <dom-module id="d2l-vaadin-date-picker-polymer1-styles"> | ||
| <template> | ||
| <custom-style> |
There was a problem hiding this comment.
You don't need the custom-style inside a dom-module template
d2l-date-picker.html
Outdated
| // on-value-changed got removed for the Polymer2 version of vaadin-date-picker, | ||
| // so for Polymer2 we'll set our own event | ||
| this._changeListener = this._handleValueChanged.bind(this); | ||
| this.addEventListener('value-changed', this._changeListener); |
There was a problem hiding this comment.
Why does this not work in polymer 1?
Date picker slot
