US158420 - Add option to allow usage of clipboard in iframes #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant-cleary
approved these changes
Oct 11, 2023
NicholasFlorian
approved these changes
Oct 11, 2023
|
Can you add this to the README? |
|
I got a notification that you pushed a change to the README... but I'm not seeing it here in the review. Is GH bugging out? |
Yeah appears to be, looks like it's processing my push |
|
Anyone know if this is safe to merge? Or do I need to wait for Github to stop bugging out? |
dlockhart
approved these changes
Oct 11, 2023
|
Couldn't merge so pushed an empty commit and that seemed to kick it into gear. 🤷♂️ |
|
🎉 This PR is included in version 0.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
clipboard-writepermission to allow us to use the clipboard API in folio-apphttps://web.dev/articles/async-clipboard#permissions_policy_integration
Relevant LMS PR:
https://github.com/Brightspace/lms/pull/41825