Closes Issue #16 #20
Open
Closes Issue #16 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails against
@BrianSipple There are several pieces of info about this out-and-about (this being one of them - FineUploader/fine-uploader-wrappers#1) where the problem has to do with using PhantomJS rather than say Chrome. Is this something that you can/will tackle or do you want me making changes to your build config as well? This PR also ties into addressing #5 but I was going to add documentation to the site when closing it but before I take any more steps I want to see if these PRs will be merged, how we want to split the work up, etc. |
This was referenced Apr 10, 2018
lancedikson
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Fix errors when consumer "app" is an ember addon.
Related to ember-cli/ember-cli#3718