Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Attrs Subclassing #35

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix Attrs Subclassing #35

merged 2 commits into from
Sep 21, 2023

Conversation

BrianPugh
Copy link
Owner

#34 fixed directly subclassing Registry when using an attrs decorator. This PR fixes subclassing the resulting class when using an attrs decorator.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e2303f) 100.00% compared to head (a9a7ba9) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          265       284   +19     
  Branches        53        60    +7     
=========================================
+ Hits           265       284   +19     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
autoregistry/_registry.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrianPugh BrianPugh merged commit 48d41cd into main Sep 21, 2023
12 checks passed
@BrianPugh BrianPugh deleted the attrs-subclass branch September 21, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants