-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generating results for a sequential modeling pipeline (to compare to our current pipeline) #132
Open
ejiawustl
wants to merge
1
commit into
BrentLab:dev
Choose a base branch
from
ejiawustl:adding_sequential_pipeline
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in your results_20241202, I see this pattern:
Where there is a directory with the same name nested under the other. As far as I know, this wasn't happening before. It isn't immediately clear to me that it is in this line that this occurs, but nowhere else stands out.
On a related note: somewhere in the docs, in the cmd line
--help
, or even as a README that gets deposited in every results otuput directory, there needs to be a definition of what "sequential_top_genes_results" are.I agree with you that keeping this in the main workflow for now (meaning, not creating another cmd line option to turn this feature on and off) is a good idea. It just needs to be documented so that it is clear what these results are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this, it looks good to me in terms of format. I haven't pulled and run this, and
__main__
is where my testing is not strict. My strategy is to implement the logic elsewhere, and do only very simple things that I am quite certain of in__main__
(not a strong strategy). Please do make sure that you go over your added code carefully. Play with it in a console/notebook if you need to be sure of something.