Non-Id primary keys #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed primary key of the table instead of using `nodeId` - which would be inconsitent and not work for all cases e.g. `GET_MANY`. Added tests
Codecov Report
@@ Coverage Diff @@
## next #74 +/- ##
=========================================
+ Coverage 0 76.77% +76.77%
=========================================
Files 0 8 +8
Lines 0 267 +267
Branches 0 72 +72
=========================================
+ Hits 0 205 +205
- Misses 0 33 +33
- Partials 0 29 +29
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses general issues with the current non-id primary keys implementation with
nodeId.It will fix related mutations like delete, update etc. mentioned in #71.
This is a potential breaking change, as the current behaviour was broken 😞 and workaround might be introduced to mitigate the issue.