Delete by nodeId doesn't work

[K-Markopoulos]

I have a relation table that doesn't have an id column and I'm trying to delete a record by nodeId with custom mutation. I get the following error:

Variable "$input" of type "Delete[RELATION]Input!" used in position expecting type "Delete[RELATION]ByNodeIdInput!"

Seems like that Delete${resourceTypename}Input doesn't match with the input of ${deleteResourceName} as the latter includes the ByNodeId. Also, the variables object for this mutation (input: { id }) is incompatible with DeleteByNodeId which expects input { nodeId }.

Code of interest:

ra-postgraphile/src/buildQuery.ts

Lines 243 to 252 in 41e4a29

	case DELETE: {
	return {
	variables: {
	input: {
	id: mapType(primaryKeyType, (params as DeleteParams).id),
	},
	},
	query: gql`
	mutation ${deleteResourceName}($input: Delete${resourceTypename}Input!) {
	${deleteResourceName}(input: $input) {

Is this a bug or is there another way to delete a record when the table doesn't have id column? I tried some changes. but I wanted to make sure I'm not doing something wrong before I open a PR.

The following changes resolve the issue, but I'm not sure how to test them for other cases.

diff --git a/src/buildQuery.ts b/src/buildQuery.ts
index b21081d..9eddc24 100644
--- a/src/buildQuery.ts
+++ b/src/buildQuery.ts
@@ -243,12 +243,15 @@ export const buildQuery = (introspectionResults: IntrospectionResult, factory: F
     case DELETE: {
       return {
         variables: {
-          input: {
-            id: mapType(primaryKeyType, (params as DeleteParams).id),
-          },
+          input: mapInputToVariables(
+            params,
+            typeMap[`${capitalize(deleteResourceName)}Input`],
+            type,
+            typeMapConfiguration
+          ),
         },
         query: gql`
-          mutation ${deleteResourceName}($input: Delete${resourceTypename}Input!) {
+          mutation ${deleteResourceName}($input: ${capitalize(deleteResourceName)}Input!) {
             ${deleteResourceName}(input: $input) {
             ${singleLowerResourceName} {
             ${createQueryFromType(

[BowlingX]

Hi :) sorry for the late reply. This is indeed a bug; It actually affects more queries. I will Push a fix and add tests for this case. Thank you!

[BowlingX]

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

• GitHub release
• npm package (@next dist-tag)

Your semantic-release bot 📦🚀

[BowlingX]

I reworked the non-id primary key logic and removed nodeId from the current implementation; Instead I alias the pimary key name to create a consistent behaviour for all queries. I released it under the next tag in npm; Please try it out if it works for your usecase.

[K-Markopoulos]

Thanks for the fix! It works fine for non-id primary keys, but unfortunately it doesn't work when primary key consists of 2 columns, like relationship tables.
The queries are now using only the first key, but all keys are required.

[BowlingX]

Yes, indeed that might be a problem; I will check if I can implement something for this case; Not all features are supported then, but at least fetch one update etc should work.

[BowlingX]

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀