Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#82] github AccessToken 관련 에러처리 #73

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[#82] github AccessToken 관련 에러처리 #73

merged 1 commit into from
Apr 17, 2024

Conversation

namewhat99
Copy link
Contributor

이슈

고민한 내용

  • iOS 에서 잘못된 accessToken 을 보내준 경우, 일단 badRequest 를 던지게 하였다.

@namewhat99 namewhat99 requested a review from koomin1227 April 17, 2024 03:36
koomin1227
koomin1227 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@koomin1227 koomin1227 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apple Auth랑 비슷한 오류 형식이네요. 좋습니다.

@koomin1227 koomin1227 merged commit cb9beb3 into develop Apr 17, 2024
1 check passed
@koomin1227 koomin1227 deleted the feature/githubError-#82 branch April 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koomin1227 koomin1227 koomin1227 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namewhat99 @koomin1227