Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#58] apple 로그인 과정에서 token expire 에러 처리 #59

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

namewhat99
Copy link
Contributor

이슈

고민한 내용

  • iOS 측에서 받아 온 jwt 토큰이 expired 되었을때, 이에 대한 에러 처리가 필요했다
  • TokenExpiredError 가 나오면 UnAuthorizedException 으로 바꿔서 처리
  • 다른 예외들은 그대로 던진다

@namewhat99 namewhat99 requested a review from koomin1227 April 13, 2024 09:50
return null;
}
} catch (e) {
if (e instanceof TokenExpiredError) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요 기존에 전부 다 잡아내는 것보다는 훨신 더 좋은 방법인것 같습니다.

@koomin1227 koomin1227 merged commit 3028fc7 into develop Apr 13, 2024
1 check passed
@koomin1227 koomin1227 deleted the feature/catchError-#58 branch April 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants