Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#055] 회원가입해야하는 경우를 알려주는 표시 추가 #56

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

koomin1227
Copy link
Member

@koomin1227 koomin1227 commented Apr 12, 2024

이슈

체크리스트

  • 로그인 응답으로 회원가입 여부 응답

고민한 내용

회원가입 여부 표시

  • user가 존재해서 로그인이 된 경우와 존재 하지 않아서 회원가입이 필요한 경우를 구분하는 필드를 추가 했다.
{ 
accessToken, 
refreshToken, 
isMember 
}
  • 회원가입을 진행하다가 앱을 종료한 경우도 고려 해야하기 때문에 유저 정보가 전부 입력되지 않는 경우 회원가입이 되지 않은 것으로 판단 했다

@koomin1227 koomin1227 requested a review from namewhat99 April 12, 2024 17:45
@koomin1227 koomin1227 self-assigned this Apr 12, 2024
!user.studentId ||
!user.major ||
!user.nickname
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세종인증 이나 닉네임 입력 중간에 회원이 나가는 경우도 커버가 되나 확인해봤는데 괜찮을듯 하네요. create 가 아니라 update 작업이라 문제 없을듯 합니다 굳굳

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 좋습니다!

@namewhat99 namewhat99 merged commit 9e9ad26 into develop Apr 13, 2024
1 check passed
@koomin1227 koomin1227 deleted the feature/changeSignup-#55 branch April 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants