[#41] 학점 등록 / 수정 기능 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koomin1227
approved these changes
Apr 9, 2024
| const isExist = await this.gradeRepository.findOne(userId); | ||
|
|
||
| if (!isExist) { | ||
| throw new BadRequestException('등록된 학점정보가 없습니다'); |
There was a problem hiding this comment.
개인적인 생각으로는 NotFound 가 더 어울리지 않을까 생각이됩니다.
There was a problem hiding this comment.
아 오키오키 반영해서 올리겠읍니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
고민한 내용