[#034] 인가 구현 #35
Merged
[#034] 인가 구현 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namewhat99
reviewed
Apr 9, 2024
| async validate(payload: any) { | ||
| return { userId: payload.userId }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Request 의 user 필드에 userId를 담는다
|
|
||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
Ownership 에서는 AuthGuard 를 통과한 요청들에 request.user.userId 가 담겨있다. 이 userId 와 파라미터의 Id 를 비교해 해당 리소스를 소유한 사람인지 비교한다
namewhat99
approved these changes
Apr 9, 2024
| secretOrKey: configService.get('JWT_SECRET'), | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
jwt 를 만드는 라이브러리랑 검증하는 라이브러리랑 달라서 그런데 혹시 postman 으로 했을때 통과됐나요? jwt token 은 @nestjs/jwt 에서 generate 되고 검증은 @nestjs/passport 를 사용해서 혹시나해서, 테스트 통과했으면 좋습니다~
There was a problem hiding this comment.
넵 통과 됩니다. passport 에서 jwt strategy를 사용해서 jwt 확인 가능합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
체크리스트
고민한 내용
권한 가드 (OwnershipGuard)