Add a basic stack-tracking mechanism for easier debugging. #11
Conversation
|
I think you could just use a regular "volatile boolean" here rather than an AtomicBoolean. The latter is useful if you need the CAS method, which this commit doesn't seem to use. |
|
I'd watch out for |
| executor.execute(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| final ArrayList<StackTraceElement> previousStack = stackTrace.get(); | ||
| stackTrace.set(currentStack); |
There was a problem hiding this comment.
Could you add a comment about the impact of setting the threadlocal here/what it's intended to do?
|
Overall looking pretty good/useful -- just the comments listed above :) |
|
@bklimt are you intending to update this? If not I will clone your branch, make the modifications and submit as a new PR. |
|
AFAIK he's not. I've also tried using this internally and I get OOM exceptions. |
|
Hmm OK, I'll give it a spin and some point see if it's worth continuing. |
|
*internally within our codebase that uses bolts, not just bolts on its own. |
|
Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email [email protected] with your details so we can update your status. |
No description provided.