DJANGO_DRAMATIQ_TASKS_NOT_WRITES, DJANGO_DRAMATIQ_TASKS_WRITES_ONLY #163
Conversation
|
|
||
| class TaskManager(models.Manager): | ||
| def create_or_update_from_message(self, message, **extra_fields): | ||
| def create_or_update_from_message(self, message, **extra_fields) -> Optional['Task']: |
There was a problem hiding this comment.
nitpick:
| def create_or_update_from_message(self, message, **extra_fields) -> Optional['Task']: | |
| def create_or_update_from_message(self, message, **extra_fields): |
I dont believe we are using types in this project. Can you please remove this for consistency? 😄
There was a problem hiding this comment.
I suggest adding types everywhere, it always makes it easier to read the code. Compatibility will not be affected: in the library "Requirements Python 3.9+"
| def create_or_update_from_message(self, message, **extra_fields) -> Optional['Task']: | ||
|
|
||
| # black and write lists | ||
| if DJANGO_DRAMATIQ_TASKS_WRITES_ONLY and message.actor_name not in DJANGO_DRAMATIQ_TASKS_WRITES_ONLY: |
There was a problem hiding this comment.
suggestion: Since you default to an empty list in the getattr method above, the first part of this conditional should not be necessary.
| if DJANGO_DRAMATIQ_TASKS_WRITES_ONLY and message.actor_name not in DJANGO_DRAMATIQ_TASKS_WRITES_ONLY: | |
| if message.actor_name not in DJANGO_DRAMATIQ_TASKS_WRITES_ONLY: |
There was a problem hiding this comment.
False-like vals will not works this way. For example - None
| def create_or_update_from_message(self, message, **extra_fields): | ||
| def create_or_update_from_message(self, message, **extra_fields) -> Optional['Task']: | ||
|
|
||
| # black and write lists |
There was a problem hiding this comment.
nitpick:
| # black and write lists |
Done |
Allow to specify which actors to write to the database with "black" and "white" lists: