Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix incorrect option "disassociate" in "checkoutSCM" git section #608

Merged

Conversation

kenlau46
Copy link
Contributor

@kenlau46 kenlau46 commented Jan 8, 2025

Bob return failure when use disassociate in checkoutSCM section

Parse error: Error while validating recipes/bob.yaml: Key 'checkoutSCM' error:
Wrong key 'disassociate' in {'scm': 'git', 'url': '[email protected]:BobBuildTool/bob.git', 'branch': 'master', 'singleBranch': True, 'shallow': 1, 'disassociate': True}

Browse through the source code and dissociate is defined and used instead.

Also fix typo and add man page section that explains the option

Also fix typo and add man page section that explains the option
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (c1146f8) to head (f11e2fb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   88.86%   88.84%   -0.03%     
==========================================
  Files          48       48              
  Lines       15468    15467       -1     
==========================================
- Hits        13745    13741       -4     
- Misses       1723     1726       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkloetzke
Copy link
Member

Good catch. The documentation obviously misspelled the option. Thanks!

@jkloetzke jkloetzke merged commit e325c8a into BobBuildTool:master Jan 8, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants