fix unit tests on arch linux #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 48 48
Lines 15463 15468 +5
=======================================
+ Hits 13739 13744 +5
Misses 1724 1724 ☔ View full report in Codecov by Sentry. |
jkloetzke
reviewed
Dec 30, 2024
rhubert
force-pushed
the
git-fixes
branch
2 times, most recently
from
f0cfa1c to
b538860
Compare
jkloetzke
reviewed
Jan 5, 2025
CreateTarget is called with a relative target directory. In case the directory is the root-directory (`/`) the path passed to CreateTarget is just an empty string which fails in `mkdir` with: src/namespace-sandbox/namespace-sandbox.c:471: cannot create : No such file or directory This happens for example on systems where the home directory of nobody in /etc/passwd is `/`.
Make tests work on machines where the git init.defaultBranch is set to something different than master.
GNU Inteutils and net-tools hostname implementations don't support `-A`. Looks like this is available on debian only. Use the hostid tool instead.
If the java version is to new for the lastest jenkins release it refuses to start: [TEST]: Waiting for Jenkins to get ready... Running with Java 23 from /usr/lib/jvm/java-23-openjdk, which is not yet fully supported. Run the command again with the --enable-future-java flag to enable preview support for future Java versions. Supported Java versions are: [17, 21] See https://jenkins.io/redirect/java-support/ for more information.
The fix for CVE-2022-39253 ([1]) disallows file mode transfers for submodules. Since (at least) our unit tests rely on file transfers allow it if file protocol is used. [1] https://www.cve.org/CVERecord?id=CVE-2022-39253
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of small fixes and adjustments to get the unit tests working on arch linux based distributions using the latest versions of git, different
hostname, latest java, ...