Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:920604] Bluetooth: MGMT: Fix slab-use-after-free Read in mgmt_remove_adv_monitor_sync #2633

Open
wants to merge 1 commit into
base: workflow
Choose a base branch
from
Open

[PW_SID:920604] Bluetooth: MGMT: Fix slab-use-after-free Read in mgmt_remove_adv_monitor_sync #2633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion net/bluetooth/mgmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5388,10 +5388,16 @@ static void mgmt_remove_adv_monitor_complete(struct hci_dev *hdev,
{
struct mgmt_rp_remove_adv_monitor rp;
struct mgmt_pending_cmd *cmd = data;
struct mgmt_cp_remove_adv_monitor *cp = cmd->param;
struct mgmt_cp_remove_adv_monitor *cp;

if (status == -ECANCELED ||
cmd != pending_find(MGMT_OP_REMOVE_ADV_MONITOR, hdev))
return;

hci_dev_lock(hdev);

cp = cmd->param;

rp.monitor_handle = cp->monitor_handle;

if (!status)
Expand All @@ -5409,6 +5415,10 @@ static void mgmt_remove_adv_monitor_complete(struct hci_dev *hdev,
static int mgmt_remove_adv_monitor_sync(struct hci_dev *hdev, void *data)
{
struct mgmt_pending_cmd *cmd = data;

if (cmd != pending_find(MGMT_OP_REMOVE_ADV_MONITOR, hdev))
return -ECANCELED;

struct mgmt_cp_remove_adv_monitor *cp = cmd->param;
u16 handle = __le16_to_cpu(cp->monitor_handle);

Expand Down
Loading