Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:918026] Bluetooth: hci: Remove deadcode #2620

Closed
wants to merge 2 commits into from
Closed

Conversation

BluezTestBot
Copy link
Owner

From: "Dr. David Alan Gilbert" [email protected]

hci_bdaddr_list_del_with_flags() was added in 2020's
commit 8baaa40 ("Bluetooth: Add bdaddr_list_with_flags for classic
whitelist")
but has remained unused.

hci_remove_ext_adv_instance() was added in 2020's
commit eca0ae4 ("Bluetooth: Add initial implementation of BIS
connections")
but has remained unused.

Remove them.

Signed-off-by: Dr. David Alan Gilbert [email protected]

include/net/bluetooth/hci_core.h | 2 --
include/net/bluetooth/hci_sync.h | 1 -
net/bluetooth/hci_core.c | 20 --------------------
net/bluetooth/hci_sync.c | 24 ------------------------
4 files changed, 47 deletions(-)

tedd-an and others added 2 commits December 12, 2024 21:24
This patch adds workflow files for ci:

[sync.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <[email protected]>
hci_bdaddr_list_del_with_flags() was added in 2020's
commit 8baaa40 ("Bluetooth: Add bdaddr_list_with_flags for classic
whitelist")
but has remained unused.

hci_remove_ext_adv_instance() was added in 2020's
commit eca0ae4 ("Bluetooth: Add initial implementation of BIS
connections")
but has remained unused.

Remove them.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Copy link

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.48 seconds
Result: PENDING

Copy link

GitLint
Desc: Run gitlint
Duration: 0.28 seconds
Result: PENDING

Copy link

SubjectPrefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.07 seconds
Result: PASS

Copy link

BuildKernel
Desc: Build Kernel for Bluetooth
Duration: 25.02 seconds
Result: PASS

Copy link

CheckAllWarning
Desc: Run linux kernel with all warning enabled
Duration: 27.23 seconds
Result: PASS

Copy link

CheckSparse
Desc: Run sparse tool with linux kernel
Duration: 30.61 seconds
Result: WARNING
Output:

net/bluetooth/hci_core.c:60:1: warning: symbol 'hci_cb_list_lock' was not declared. Should it be static?

Copy link

BuildKernel32
Desc: Build 32bit Kernel for Bluetooth
Duration: 25.28 seconds
Result: PASS

Copy link

TestRunnerSetup
Desc: Setup kernel and bluez for test-runner
Duration: 435.47 seconds
Result: PASS

Copy link

TestRunner_l2cap-tester
Desc: Run l2cap-tester with test-runner
Duration: 20.29 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants